Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: modernize base types and interfaces #87

Merged
merged 3 commits into from
Dec 29, 2023
Merged

refactor!: modernize base types and interfaces #87

merged 3 commits into from
Dec 29, 2023

Conversation

shizhMSFT
Copy link
Contributor

@shizhMSFT shizhMSFT commented Dec 29, 2023 •
edited
Loading

What this PR does / why we need it

Which issue(s) this PR resolves / fixes

Related to #38

Please check the following list

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@codecov Codecov
Copy link

codecov bot commented Dec 29, 2023 •
edited
Loading

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (e940161) 73.07% compared to head (27254f9) 72.24%.

Files Patch % Lines
src/OrasProject.Oras/Content/Extensions.cs 77.50% 6 Missing and 3 partials ⚠️
src/OrasProject.Oras/Oci/Platform.cs 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
- Coverage   73.07%   72.24%   -0.83%     
==========================================
  Files          31       33       +2     
  Lines        1040     1027      -13     
  Branches       91       91              
==========================================
- Hits          760      742      -18     
- Misses        228      232       +4     
- Partials       52       53       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Wwwsylvia
Wwwsylvia approved these changes Dec 29, 2023
View reviewed changes
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit 6adeaaa into oras-project:main Dec 29, 2023
7 checks passed
This was referenced Dec 29, 2023
Merged
Closed
@shizhMSFT shizhMSFT deleted the refactor_content branch January 2, 2024 03:28
@shizhMSFT shizhMSFT mentioned this pull request Jan 15, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wwwsylvia Wwwsylvia Wwwsylvia approved these changes

@sammychinedu2ky sammychinedu2ky Awaiting requested review from sammychinedu2ky sammychinedu2ky is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shizhMSFT @Wwwsylvia